Add hypercall_filter.py test under host_sb for 9.0 - #637
Draft
CocoElAbricot wants to merge 1 commit into
Draft
Conversation
dinhngtu
requested changes
Jul 21, 2026
|
|
||
| # Requirements: | ||
| # - one XCP-ng host (--host) >= 9.0 | ||
| # - Host Secureboot enforcement must be enabled |
Member
There was a problem hiding this comment.
If this is the case, you should verify it with a fixture. Optionally, also check if the Secure Boot keys etc. are in place.
Member
There was a problem hiding this comment.
Can this test go into tests/xen or is it better as a separate component?
Comment on lines
+29
to
+31
| local_binary = pathlib.Path(__file__).parent / "data" / "test_hypercall_filter" | ||
|
|
||
| remote_binary = "/tmp/test_hypercall_filter" |
Member
There was a problem hiding this comment.
It's worth discussing a better way to produce and host this sort of test binaries. At least, this test should link to the relevant tool repo.
CocoElAbricot
force-pushed
the
cop/9-HostSB
branch
from
July 22, 2026 13:05
7fc1576 to
5caecf9
Compare
Author
|
Last force push: Just using plain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test covering the hypercall filter functionality.
This is my first contribution to the xcp-ng test suite, so I'd appreciate guidance on best practices, test structure, naming conventions, or anything I might be missing to align with the project's standards.